johnynek / bosatsu

A python-ish pure and total functional programming language
Apache License 2.0
223 stars 11 forks source link

Encode Kinds to Longs in proto #1087

Closed johnynek closed 7 months ago

johnynek commented 7 months ago

this is just to save a few bytes in the proto since most commonly we just have a few kinds, and those can be represented by 1 byte in almost all common cases.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5268549) 92.53% compared to head (313a0d7) 92.56%.

Files Patch % Lines
...main/scala/org/bykn/bosatsu/TypedExprToProto.scala 76.92% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1087 +/- ## ========================================== + Coverage 92.53% 92.56% +0.03% ========================================== Files 93 93 Lines 10364 10414 +50 Branches 2367 2465 +98 ========================================== + Hits 9590 9640 +50 Misses 774 774 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.