search

johnynek / bosatsu

A python-ish pure and total functional programming language
Apache License 2.0
223 stars 11 forks source link

Attempt to fix 1108 #1109

Closed johnynek closed 6 months ago

johnynek commented 6 months ago

I tried to fix #1108 but I couldn't find a fix. It's not a real bug exactly since TotalityTest checks the laws on ill-typed patterns and the pattern in question is ill-typed.

A probably better test for TotalityCheck would be to generate well-typed patterns only, and we could probably find more issues that way.

I did find a few minor things that seemed like improvements, but since no tests changed, maybe they aren't better. Who knows.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (689bffb) 92.40% compared to head (550a982) 92.54%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1109 +/- ## ========================================== + Coverage 92.40% 92.54% +0.14% ========================================== Files 94 94 Lines 10755 10761 +6 Branches 2522 2523 +1 ========================================== + Hits 9938 9959 +21 + Misses 817 802 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.