search

johnytiago / GSR

A Netkit implementation of a network for a college project
0 stars 0 forks source link

Removing private SSH key #6

Closed oudeismetis closed 7 years ago

oudeismetis commented 7 years ago

I noticed you had commited a private ssh key to your repo.

"I know. It was intentional." Sorry to bother you then. Feel free to ignore this PR. You know you can also secure private data while keeping it under source control.

"I didn't notice. What is this file? Is it a problem?" This can be a very bad thing

"I keep accidentally typing git add ., any way I can prevent that from being an issue?" There are a couple of steps you should take immediately:

  1. Avoid commands like git add . and git add *. It's better to be more explicit when you can.
  2. Assume your key is compromised. Unassociate it from any accounts you are using it for and generate a new key.
  3. Store your keys in a location outside of your project.
  4. Use a .gitignore file to prevent accidental commits of certain files.

Github also has a page about how to remove sensitive data from a repo.

Hope this PR finds you well

johnytiago commented 7 years ago

Hey @oudeismetis! :) Is this any kind of crawler generated PR?

This project is the setup of a sample network of virtual machines which were never really used. They only serve the purpose of proving connectivity to each other. :) Thanks for the PR, will merge either way. ;)

oudeismetis commented 7 years ago

@johnytiago yep, generated PR! I have it slowly crawling Github :)