johnzero7 / XNALaraMesh

Blender addon Import/Export XPS Models, Poses
536 stars 94 forks source link

Blender 2.80 Feature - Import XPS model into New Collection #36

Closed Gnates closed 5 years ago

Gnates commented 5 years ago

Hey, happy holidays. Unfortunately, I don't have an older 2.80 beta nightly build, so I will have to wait till the Blender devs finalize the API again.

In the meantime, I do have another feature request:

johnzero7 commented 5 years ago

Thanks. Happy holidays to you too (late) and happy new Year I am mostly back. @lekarsenten was kind enough to solve the new problem with the API chances.

Good idea. I should have done it from the beginning, its a great new feature and really useful. I will make a collection for every model imported. But the name... that's a little problem. In the model file there is nothing that identifies the name of the model. Also the files are named xps.xps o generic_item.mesh, so that is another no. The only source left would be the name of the folder where the model is... that is a little too weird for my taste.

So I guess in the end all models imported will be in a collection name "XPS Model", "XPS Model.001", ... and so on.

Gnates commented 5 years ago

Yea, I had a feeling the renaming option would be severely limited, so the "XPS Model.001" is probably the best solution. Thanks!

Regarding the recent problem with the API changes, will we be able to use the nightly 2.80 beta builds again with the next version of XPS Tools?

Before I forget, will the people using Blender 2.79's XPS Tools add-on updater receive updates for the 2.80 version too? Just want to make sure people using Blender 2.79 aren't automatically updating to an incompatible version.

Have a great new year!

johnzero7 commented 5 years ago

Yes, I have been testing the changes submitted by @lekarsenten and they work flawlessly. They are already pulled to master. So use the update to get the master and voila!

Unfortunately yes. When the updater addon was incorporated, I didn't put any kind of limitation. Just in v1.8.6 I limited the upper version to download. So any release previous to v1.8.6 can potentially download an incompatible version of the addon. I read the documentation of the updater, but looks like at this point there is nothing I could do to fix this situation in previous releases (not mentioning that I could delete ALL releases, limiting the updater and re-release them all).

PS: Never mind all that. I Just found out the updater is broken too in the latest nighly build. No rest for the wicked I guess.

johnzero7 commented 5 years ago

Now the addon creates a collection for the imported model name "XPS Model". Updated and fixed the addon-updater. All changes are included in Master branch and release 1.9.1