search

johscheuer / theforeman-coreos-kubernetes

A small collection of templates used to deploy Kubernets on CoreOS with theforeman
Apache License 2.0
23 stars 8 forks source link

Typo storage.googleapis.com/kubernetes-release URL #6

Closed levmichael3 closed 8 years ago

levmichael3 commented 8 years ago

Hello, There are minor typos, with duble '<<' marks:

https://github.com/johscheuer/theforeman-coreos-kubernetes/blob/94f49b2f0dd59e0b95dcca5d1bbbfc662a5b64bf/kubernetes/standalone_cloudconfig.erb#L88

https://github.com/johscheuer/theforeman-coreos-kubernetes/blob/94f49b2f0dd59e0b95dcca5d1bbbfc662a5b64bf/kubernetes/standalone_cloudconfig.erb#L116

https://github.com/johscheuer/theforeman-coreos-kubernetes/blob/94f49b2f0dd59e0b95dcca5d1bbbfc662a5b64bf/kubernetes/standalone_cloudconfig.erb#L166

https://github.com/johscheuer/theforeman-coreos-kubernetes/blob/94f49b2f0dd59e0b95dcca5d1bbbfc662a5b64bf/kubernetes/master_cloudconfig.erb#L88

https://github.com/johscheuer/theforeman-coreos-kubernetes/blob/94f49b2f0dd59e0b95dcca5d1bbbfc662a5b64bf/kubernetes/master_cloudconfig.erb#L116

https://github.com/johscheuer/theforeman-coreos-kubernetes/blob/94f49b2f0dd59e0b95dcca5d1bbbfc662a5b64bf/kubernetes/master_cloudconfig.erb#L163

johscheuer commented 8 years ago

Thank you very much! :+1:

levmichael3 commented 8 years ago

Cheers. I'm trying to make it work on my Foreman by the way. Can't make it work yet, might be due to tabs and spaces.

johscheuer commented 8 years ago

You are right there was a mistake with a tab I fixed this issue in the latest commit. Sorry for that! I also added https://coreos.com/validate which is a handy tool to check your cloud-init.

levmichael3 commented 8 years ago

@johscheuer : Thanks! I've just found out about it and it really helps! Have you succeeded using it with the wrapper Foreman provision?