README "k8s_master" should not include http tag

johscheuer / theforeman-coreos-kubernetes

A small collection of templates used to deploy Kubernets on CoreOS with theforeman

Apache License 2.0

23 stars 8 forks source link

README "k8s_master" should not include http tag #8

Closed JohnCoconut closed 8 years ago

JohnCoconut commented 8 years ago

In README.md,

k8s_master: The Kubernetes master e.g. http://172.24.1.148.

however, in minion_cloudconfig.erb

initial-cluster: master=http://<%= @host.params['k8s_master'] %>:2380

This combination will generate a template like this,

initial-cluster: master=http:// http://172.24.1.148

johscheuer commented 8 years ago

@mywtfmp3 thanks for reporting this issue I will fix the documentation. I probably changed this with etcd2 and forgot to adjust the docs :)

johscheuer commented 8 years ago

If you still have any issues running it please feel free to ask :)

JohnCoconut commented 8 years ago

@johscheuer Thanks for fixing it.:) I haven't been able to get cluster running with templates. But it's a very good start for me. Once I figure out the issues, I will report back.