search

johsin18 / DevicePixelRatioMatomoPlugin

3 stars 1 forks source link

If dpr initially unknown, update in subsequent page impression #4

Open seb303 opened 4 months ago

seb303 commented 4 months ago

Fix to address the issue mentioned here: https://github.com/johsin18/DevicePixelRatioMatomoPlugin/issues/3

Have submitted a similar PR for the Matomo Core Resolution plugin. https://github.com/matomo-org/matomo/pull/22080

johsin18 commented 3 months ago

Hi seb303, I support your PR. However, could you please make it more complete

seb303 commented 3 months ago

Hi johnsin18, I've updated the FAQ. I don't feel confident to add a test though as I'm not familiar with the testing framework used. I'm more likely to break something than to make the code safer! Sorry.

johsin18 commented 2 months ago

Hi seb303, I'm on it, have to get back into the whole topic. Please have a bit more patience. johsin18