search

johvin / eslint-import-resolver-alias

a simple Node behavior import resolution plugin for eslint-plugin-import, supporting module alias
MIT License
181 stars 10 forks source link

peerDependency of eslint #2

Closed JakeSidSmith closed 6 years ago

JakeSidSmith commented 6 years ago

It doesn't appear to be mentioned anywhere which version of eslint this is compatible with. This should be added as a peer dependency to ensure users have the correct version installed.

I'd recommend making this a bit flexible e.g.

"eslint": ">=3.x.x"
johvin commented 6 years ago

@JakeSidSmith thanks for your suggestion. It's a good idea to add a peer dependency. Actually, eslint-import-resolver-alias is one of eslint-plugin-import resolvers. So I think the following config is better.

"eslint-plugin-import": ">=1.4.0"
JakeSidSmith commented 6 years ago

Okay, thanks @johvin , that'd be fine.

johvin commented 6 years ago

done in 1.0.4