joie / joie-web-app

Joie pairs you with world-class teachers to help you build a healthier and happier life – one step at a time.
https://joie.co
0 stars 0 forks source link

Can't delete session #165

Closed yinonov closed 3 years ago

yinonov commented 3 years ago

Describe the bug Session doesn't have a delete button

Expected behavior Session should have a delete button

Screenshots image

Additional context

create a firebase cloud callable function to enable deletion if:

(all following conditions should be validated both on client & backend)

Deletion of session should affect references such as:

btw @LolaRev we should define a process for deletion of published sessions

yinonov commented 3 years ago

Enhanced by: #166

LolaRev commented 3 years ago

Delete a session

@yinonov please review and let me know your thoughts.

Once a teacher creates a session they can delete it only if no one is enrolled in the session.

Cancel a session (it is the same action as delete but with a different scenario)

A teacher can cancel a session (delete it), if there are students enrolled, in case of an emergency. If they cancel, there should be an automatic email sent to the students. The email will be sent through MailChimp, and the students get a full refund.

Edit session

Only the following fields can be edited after the session is done:

ilirhushi commented 3 years ago

@LolaRev where do you think we can place the DELETE button & CANCEL button in terms of UI?

LolaRev commented 3 years ago

@ilirhushi we can add it here. image

Also, here if possible for a quick edit. image

It should be available only for the session creator.

ilirhushi commented 3 years ago

@yinonov @LolaRev what happens when user hits DELETE because the reference will be deleted, will we redirect to some other page?

Screenshot 2020-10-21 at 5 36 34 PM

LolaRev commented 3 years ago

my suggestion the list of sessions under the account. @yinonov thoughts?

LolaRev commented 3 years ago

@yinonov delete session works from my end. I can't test the scenario where there are already students signed for it. Any suggestions? Also, I didn't see it on the session's card.

yinonov commented 3 years ago

@LolaRev we don't really know how to display it and where. We can do like a "more" icon to open a menu with edit, delete etc'...

LolaRev commented 3 years ago

@yinonov yes. Please add it as a side menu. See this example: IMG_20201023_132435.jpg

For the card, there are 3 dots on the design.

yinonov commented 3 years ago

Delete a session

@yinonov please review and let me know your thoughts.

Once a teacher creates a session they can delete it only if no one is enrolled in the session.

Cancel a session (it is the same action as delete but with a different scenario)

A teacher can cancel a session (delete it), if there are students enrolled, in case of an emergency. If they cancel, there should be an automatic email sent to the students. The email will be sent through MailChimp, and the students get a full refund.

Edit session

Only the following fields can be edited after the session is done:

  • Promotion (if they want to add a discount, etc)
  • Description, goals, name, what's needed - also can be edited but we will make sure to tell the teachers they can't change the assent of the session once someone is enrolled.
  • add or change the thumbnail, intro video. All the other fields can't be changed.

partially issued by #176