search

joie / joie-web-app

Joie pairs you with world-class teachers to help you build a healthier and happier life – one step at a time.
https://joie.co
0 stars 0 forks source link

remove lodash dependencies #196

Closed yinonov closed 3 years ago

yinonov commented 3 years ago

Is your feature request related to a problem? Please describe. lodash import might be importing the full lodash library unless tweaked properly

Describe the solution you'd like remove lodash dependency in favour of own functions implementations

Describe alternatives you've considered use ramda as it provides dedicated modules for each function

Additional context https://github.com/joie/joie-web-app/blob/e57e9ad03a1e8a5a83020cf67c79af96b695e99c/apps/joie/src/app/session-form/containers/session-form/session-form.component.ts#L19

ilirhushi commented 3 years ago

@yinonov should I use lodash.get instead?

https://www.npmjs.com/package/lodash.get

yinonov commented 3 years ago

Seems better yeah