joie / joie-web-app

Joie pairs you with world-class teachers to help you build a healthier and happier life – one step at a time.
https://joie.co
0 stars 0 forks source link

Create a session flow #93

Open LolaRev opened 4 years ago

LolaRev commented 4 years ago

Describe the bug When creating a session, after entering the basic information and click on submit nothing happens.

To Reproduce

  1. Go to account
  2. Click on sessions > add a new session
  3. add the basic info (without show all details)
  4. click submit

Expected behavior Per my talk with @yinonov it was supposed to save the session details so that I can edit them later. if that's the case the button is not responding. if we decided to change it, the button should not be active until all the fields are completed.

Screenshots image

yinonov commented 4 years ago

it's just not hooked yet. work in progress.

btw @LolaRev do we want the thumbnail image to be uploaded on this session metadata form or inside the session page?

LolaRev commented 4 years ago

@yinonov Whatever is easier for you. I will create a guide for them on how to set the page so as long as the interface is easy and intuitive I'm ok with both.

pratheeshkumarrd commented 4 years ago

@yinonov, I have a question here. As Dikla said, we can create a session and later we can edit the details. But the current implementation is like while creating the session itself we schedule a Kaltura event and assign that event id to this session and store it. The Kaltura event info can't be modified. Meaning the schedule date can't be changed. Once it's created that's it. So only the possible solution is every time when we edit the session details we have to create a new event for live streaming when the date changes. What's your opinion on this?

pratheeshkumarrd commented 4 years ago

@LolaRev, Description field is not a mandatory one?

LolaRev commented 4 years ago

@pratheeshkumarrd it is a mandatory field.

pratheeshkumarrd commented 4 years ago

Ok fine. Then we have to add a * to indicate it's mandatory field

LolaRev commented 4 years ago

@pratheeshkumarrd all fields other than the need to know, promotion, and the cross sell are mandatory. So I would do the other way around and write optional for those two.

yinonov commented 4 years ago

They don't have to be mandatory as the form is long. We should add these as drafts at first and require all mandatory fields if user wants to publish the session. Think it's complicated?

yinonov commented 4 years ago

Ok fine. Then we have to add a * to indicate it's mandatory field

It will show * automatically if required

yinonov commented 4 years ago

@yinonov, I have a question here. As Dikla said, we can create a session and later we can edit the details. But the current implementation is like while creating the session itself we schedule a Kaltura event and assign that event id to this session and store it. The Kaltura event info can't be modified. Meaning the schedule date can't be changed. Once it's created that's it. So only the possible solution is every time when we edit the session details we have to create a new event for live streaming when the date changes. What's your opinion on this?

We can assign this task to cloud function to listen for session date update and request the new event. Btw Are non relevant events get garbage collected? Should they?