search

joielechong / CountryCodePicker

Country Code Picker (CCP) is an android library which provides an easy way to search and select country phone code ( national code ) for the telephone number.
Apache License 2.0
317 stars 145 forks source link

Minor accessibility issue #120

Open davidmcdermott2 opened 2 years ago

davidmcdermott2 commented 2 years ago

Steps to produce issue

  1. Ensure your Android device supports Talkback (screen reader) and turn it on
  2. Ensure the CountryCodePicker has a country preference set
  3. Open the CountryCodePicker dialog and scroll through the list of countries
  4. The horizontal divider line will be read as "unlabeled" by Talkback without these changes which would be confusing to users
  5. With this PR the divider will be read as "country preference divider" instead

It's possible to set the divider as skippable by Talkback but this requires bumping min sdk from 14 to 16

davidmcdermott2 commented 2 years ago

Hello I have removed the default US preference. No reason for it. Thank you