search

join-monster / join-monster-graphql-tools-adapter

Use Join Monster to fetch your data with Apollo Server.
140 stars 20 forks source link

Fix undefined resolveType issue #11

Open adelsz opened 6 years ago

adelsz commented 6 years ago

Interface and union types resolveType resolution was broken. GraphQLInterfaceType, GraphQLUnionType were missing the resolveType after joinMonsterAdapt. This happened because resolveType field should be set at type level and not in type._typeConfig.

frederikhors commented 6 years ago

@adelsz is this related to this? https://github.com/acarl005/join-monster-graphql-tools-adapter/issues/12

adelsz commented 6 years ago

@frederikhors I don't think so. type._typeConfig is defined in this case.

lorensr commented 4 years ago

@adelsz is this still an issue in the 0.1.0 version I just published?

lorensr commented 4 years ago

It includes these changes:

https://github.com/acarl005/join-monster-graphql-tools-adapter/pull/15/files

adelsz commented 4 years ago

Unfortunately, I won't be able to check this any time soon. But it shouldn't be too hard to check/reproduce with a mock GraphQLInterfaceType