search

join-monster / join-monster-graphql-tools-adapter

Use Join Monster to fetch your data with Apollo Server.
140 stars 20 forks source link

Hack to get GraphQL 14 to work #15

Closed flippidippi closed 4 years ago

flippidippi commented 5 years ago

Using the hack seen here https://github.com/acarl005/join-monster/issues/352#issuecomment-423985030, this allows join-monster-graphql-tools-adapter to work with GraphQL 14 until graphql-js adds something like extensions described here https://github.com/graphql/graphql-js/issues/1527.

This could, for the time being, fix #12

flippidippi commented 5 years ago

@acarl005 Is this repo dead?

lorensr commented 4 years ago

@flippidippi @GlennMatthys Now that extensions have been added to graphql@14.5.0, what's the non-hacky way to do this?

https://github.com/graphql/graphql-js/releases/tag/v14.5.0 https://github.com/graphql/graphql-js/pull/2097

flippidippi commented 4 years ago

I haven't done any research into how to get it working with the new graphql

lorensr commented 4 years ago

@flippidippi thanks for the response and PR—released in v0.1.0