search

joinbox / eslint-config-joinbox

Joinbox ES Linter Configuration
MIT License
0 stars 0 forks source link

fix: allow for of loops #4

Closed linaGirl closed 6 years ago

linaGirl commented 6 years ago

I can't figure what's not OK with them in some cases (like when working on async code). Airbnbs argumentation is about immutability. Mine is about readability and ease of use. I like iterators, they are great! See https://github.com/airbnb/javascript#iterators-and-generators and https://github.com/airbnb/javascript/issues/1122#issuecomment-259876436

fxstr commented 6 years ago

Suggestion is okay with me and definitly makes sense for async operations. It's up to the programmer to use and up to the reeviwer to ensure the (better fitting) Array methods whenever possible. Please inform the team.

linaGirl commented 6 years ago

i'd like to add the "no-await-in-loop": "off" rule so that i actually can use async operations inside of a loop. What's your take on that @fxstr ?

fxstr commented 6 years ago

@eventEmitter Should we update https://github.com/joinbox/guidelines?