search

joindin / callingallpapers-api

The API to power callingallpapers.com
https://callingallpapers.com
MIT License
8 stars 6 forks source link

[Closes 23] Trim trailing slash on event URIs #39

Closed paulinevos closed 6 years ago

paulinevos commented 6 years ago

Closes 23

Events were being duplicated as their URIs are used as unique identifiers, but the same URI might sometimes have a trailing slash and sometimes not.

This trims the URI on the entity when setting it.

paulinevos commented 6 years ago

Not sure if this project is still active though...

heiglandreas commented 6 years ago

Hey Pauline! Awesome! Thanks for spotting and providing a fix for the issue!

I'll check the code and get back to you ASAP.

And yes: The project is still active ;-)

heiglandreas commented 6 years ago

Looks like I need to check the build-chain also 😥 (Not your fault!)

paulinevos commented 6 years ago

@heiglandreas Yep, that's to do with the issue I opened :) Just fails because of the non-existent dependency, that's all.

heiglandreas commented 6 years ago

Thanks for your work! 👍

paulinevos commented 6 years ago

Thanks for accepting my first open source PR ever ;)

heiglandreas commented 6 years ago

You're very welcome! :-)