search

joindin / joindin-web2

HTTP Frontend For the Joind.in API
BSD 3-Clause "New" or "Revised" License
97 stars 175 forks source link

Improve local dev #887

Closed lfbittencourt closed 4 years ago

lfbittencourt commented 4 years ago

I followed README-local-dev.md instructions to run the project for the first, however several static assets as JavaScript files were missing since they were not listed in web/index.php static file extensions. I replaced that part with a regular expression and added all missing extensions that I found.

This PR also includes a little extra instruction about how to use Docker to run a Redis instance.

svpernova09 commented 4 years ago

I don't think we want to make changes to index.php to make things in local dev work. Will defer to @dstockto or @ericpoe

lfbittencourt commented 4 years ago

@svpernova09 The static files check already exists, so it's a simple fix IMO. Let me know if I can do any improvements on this!

lfbittencourt commented 4 years ago

@ericpoe Thanks! I followed your advice and updated README-local-dev.md file. Note, however, that it doesn't address @svpernova09 question about index.php static assets checking.

I think it was wrong mix both things on the same PR, but do you think we can merge it now? I can close this one and submit two separated PRs if you prefer.

ericpoe commented 4 years ago

Thanks for updating the instructions, that will certainly help the docker users.

Yes, this PR could have been two separate PRs since it fixes two completely separate problems, which makes reviewing and merging a lot easier.

ericpoe commented 4 years ago

I am trying to recreate the problem that the code portion of this PR is fixing. Where are you seeing missing assets? Is this in a specific tool? In dev vs production?