search

joindin / joindin-web2

HTTP Frontend For the Joind.in API
BSD 3-Clause "New" or "Revised" License
97 stars 175 forks source link

Bail out more carefully when Slim asks the app to halt #899

Closed iansltx closed 4 years ago

iansltx commented 4 years ago

e.g. when redirecting as a result of the trailing slashes middleware; this should allow the normal app life cycle to operate on a redirect or the like rather than throwing an exception, turning a redirect into a 500.

Looked at how Slim 2's run() method works and this seems to be the best bet to resolve.

heiglandreas commented 4 years ago

Looks good from my point.

iansltx commented 4 years ago

Whoops, had some stray bits in there, and this was out of date. Let's try that again.