search

joindin / joindin-web2

HTTP Frontend For the Joind.in API
BSD 3-Clause "New" or "Revised" License
97 stars 175 forks source link

Feature/symfony34 #903

Open zghosts opened 3 years ago

zghosts commented 3 years ago

This PR updates the symfony components to version 3.4 and updates all forms and middlewares accordingly.

As test coverage is not 100% this will probably require some manual testing by the reviewer, I've tested all forms, but could use an extra pair of eyes

afilina commented 5 months ago

This looks like a stale PR. I would recommend closing it and revisit the topic at a later time (perhaps convert to an issue).

iansltx commented 5 months ago

@zghosts If you can re-roll this after deps are updated in the other outstanding PR, I'll at the very least do a code review on the changes soon, probably Monday evening (your time) of next week).