search

joindin / joindin-web2

HTTP Frontend For the Joind.in API
BSD 3-Clause "New" or "Revised" License
97 stars 175 forks source link

Cannot edit comments #904

Open endorama opened 3 years ago

endorama commented 3 years ago

Hello, as a user commenting on talks I would have expected to be able edit my comments.

This does not seems to be the case on https://joind.in

Is this expected? There is a way to edit a comment?

If not, would this be considered an acceptable feature?

iansltx commented 3 years ago

@endorama At this point comment editability isn't implemented because you want an audit log for that sort of thing, so someone can't go in, say something super offensive, then switch it back later and pretend they never said it...or the opposite for good reviews.

If you're willing to spend the time to add comment version history in a way that's backward compatible on the API side, and expose previous versions of comments in on the web side, I believe we'd accept a PR that allowed editable comments.

endorama commented 3 years ago

Hi @iansltx thanks for the explanation.

There is a little practical gap though, which is GDPR compliance. By deleting the account the service provider is most probably required (depending on geographical region and some nuances like that, but I'm not a layer) to remove all data associated to an account. I'm not a layer, but I worked on implementing GDPR guidelines so I'm pretty sure of that. In this regard, misbehaviours may still happen.

Anyway I think keeping the edit history is a very reasonable request. I'm not sure I'll have time to dig into such an extensive feature, but thanks for your answer!