Remove Facebook- and Twittter-login

joindin / joindin-web2

HTTP Frontend For the Joind.in API

BSD 3-Clause "New" or "Revised" License

97 stars 175 forks source link

Closed Sjors1985 closed 5 months ago

Sjors1985 commented 6 months ago

This PR contains removals for Twitter / X- and Facbook-login for creating an account. Both functions aren't working properly.

Closes #922

Sidenote: This is my first PR ever, so if you have feedback to optimize it, please let me know.

heiglandreas commented 6 months ago

This looks really goot! Thank you for your contribution.

I will give it a test oater today but do currently not see any issues.

Sjors1985 commented 6 months ago

Hi,

I was wondering if you had already tested my code. And I also detected my commits are Unverified. Is that okay for you?

heiglandreas commented 6 months ago

The unverified is OK (After all it's only deleting code 😁)

I have not yet managed to give it a go. It's planned for this weeek 🙈

Sjors1985 commented 6 months ago

Thanks for your response! :)

I'm going to check why my commits aren't verified

afilina commented 5 months ago

It's planned for this weeek 🙈

@heiglandreas Bump.