search

joindin / joindin-web2

HTTP Frontend For the Joind.in API
BSD 3-Clause "New" or "Revised" License
96 stars 174 forks source link

QR code link is broken #924

Open Jean85 opened 6 months ago

Jean85 commented 6 months ago

The QR code link in the talk page appears to be broken.

I.e, here: https://joind.in/event/phpday-2024/symfony-messenger-the-sharpest-tool-in-your-php-toolbox

The QR-Code (opens in new window) appears to me like this in the browser: QR-Code (opens in new window)

heiglandreas commented 6 months ago

Looks like the Google Charts API is broken....

heiglandreas commented 6 months ago

Yeah. Google discontinued QR-code generation via chart.googleapis.com. Instead one should use the nerw charts.google.com. But a search for "QR" does not result in anything....

Jean85 commented 6 months ago

It seems that the point is that they discontinued the image generation endpoint: https://developers.google.com/chart/image

heiglandreas commented 6 months ago

Yeah... Please use ~www . qr-code-generator . com/~ (or some other generator) for now until we found something decent as replacement...

EDIT: See below for a better generator!

Sorry for the inconvenience!

Jean85 commented 6 months ago

Is https://packagist.org/packages/bacon/bacon-qr-code a possible replacement?

heiglandreas commented 6 months ago

Could be. But a service that can be used via a get request would definitely be prefered 😁

Yes! We do not need to handle that. And Yes, we are doomed when someone decides to no longer support that 🙈

Jean85 commented 6 months ago

Roger. As for a temporary workaround, https://forqrcode.com/ is far better, the one you suggested tries to steer you toward signup trial and then forces its short-linking onto you :(

iansltx commented 6 months ago

I've used Bacon in the past, and it seems to be actively maintained, so switching to an implementation where we're generating the images seems like a reasonable idea. We can output as a data URI so we don't have to add an endpoint, if that's the hangup.

We'll have to use an older version of the lib for now since we haven't done the PHP 8.x upgrade on this repo yet, but that's fine for the moment.

I'll probably have time between now and Monday to get this implemented with Bacon if someone doesn't beat me to it, with either that implementation or another one.

iansltx commented 5 months ago

...and work stuff hit like a sledgehammer. I can maybe take a look at this this weekend, but won't be able to touch it prior to phpDay, though if a PR comes up I can review it.