search

joiningdata / lollipops

Lollipop-style mutation diagrams for annotating genetic variations.
GNU General Public License v3.0
182 stars 70 forks source link

Change shape parameter #22

Closed Steven-N-Hart closed 7 years ago

Steven-N-Hart commented 8 years ago

Where would I change the code to have the user input an optional shape parameter (For a given variant to not be a circle)? I'm not a GO programmer, but could try if I got pointed in the right direction.

pbnjay commented 8 years ago

For SVG output, you could change the SVG shape used on this line: https://github.com/pbnjay/lollipops/blob/master/drawing/svg.go#L84

For PNG output, you'll have to write some code to generate the shape and refer to it here: https://github.com/pbnjay/lollipops/blob/master/drawing/png.go#L96

Squares and Triangles should be pretty straightforward at least. What do you have in mind for specifying shape parameters?

pbnjay commented 7 years ago

I'm assuming you took a different direction, but if you did implement this, feel free to submit a PR.