joinmarket-webui / jam

Your sats. Your privacy. Your profit.
https://jamapp.org
MIT License
261 stars 53 forks source link

Concept: named jars (orange, strawberry, etc.) #435

Closed dergigi closed 2 years ago

dergigi commented 2 years ago

As discussed in Community Call 20. Related to #416.


2022-07-04: Updated suggestion, again from Jar 0 to Jar 4:

Benefit: Nicely maps 0-1-2-3-4 to A-B-C-D-E, removing the "nerd numbering" that starts with zero, without introducing additional confusion that would arise from switching to 1-2-3-4-5 (because JoinMarket still uses 0-1-2-3-4).


Previous suggestion, from Jar 0 to Jar 4:

Fruits are picked randomly, somwhat.^fn-jams (Tried to pick some that would map nicely to colors. Color accents should be very subtle, if present at all, to not confuse users with 'green is good' or 'red is bad'.)

dergigi commented 2 years ago

Added an updated suggestion to use A-B-C-D-E instead of numbers.

ghost commented 2 years ago

Letters instead of numbers are great! Gets rid of the awkward 0-index while keeping the mapping to the number-indexed mixdepths on the CLI reasonable.

Quick mockup just to help people visualize it:

Screenshot 2022-08-04 at 11 39 33

Obviously we'd have to find a nicely looking color scheme. This is just something quick from coolors.co. Maybe a fruit that starts with a C that's not red 🔴 would be nice. The red looks quite dangerous here...

editwentyone commented 2 years ago

with this api we could more or less randomize it even https://colornames.org/download/ example: https://colornames.org/search/results/?type=exact&query=plum

editwentyone commented 2 years ago

a labeling what also help to make it more readable: (no Jar in front, maybe no bold first letter) - what do you think?

dergigi commented 2 years ago

We had some more discussions on this in Call 21. Unless someone objects, I feel like we should strive to include this in v0.1.

I will update the docs accordingly, and unless there are volunteers I'm happy to implement this myself.

ghost commented 2 years ago

Sounds good! I'm not so sure about making the colors random, though. I feel like that might be confusing and make it harder to memorize which Jar is which. After all, the colors should be an additional memory aid, i.e. Jar A should always be orange, Jar B always be blue, etc...

dergigi commented 2 years ago

Agree! No randomness required.

ghost commented 2 years ago

Would you be able to come up with a nicely looking color scheme @editwentyone?

editwentyone commented 2 years ago

not yet, are we already fixe with the names?

Apricot Blueberry Cherry Date Elderberry

or are there other suggestions?

editwentyone commented 2 years ago
image

https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=4367%3A113433

editwentyone commented 2 years ago

Darkmode:

image

https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=5072%3A61903

editwentyone commented 2 years ago

what do you think @dnlggr ? "Date" in darkmode is possibly to red, but I think its ok to start with

dergigi commented 2 years ago

Nice, I like it!

I agree @editwentyone that Date is a bit too red when on black, and Blueberry and Elderberry might also be too close together. I'll see if I can get to implementing this before v0.1 and might play around with the colors a bit. 🎨 🧑‍🎨

editwentyone commented 2 years ago

I updated the dark mode version again, see here https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=5072%3A61903

image
dergigi commented 2 years ago

Adjusted the colors slightly, made the Date one a bit more brown and the Elderberry one a bit more violet-ish.

Let me know what you think!

image

See #476