joinmarket-webui / jam

Your sats. Your privacy. Your profit.
https://jamapp.org
MIT License
264 stars 54 forks source link

feat: ability to select jar when unlocking fidelity bond #574

Open theborakompanioni opened 1 year ago

theborakompanioni commented 1 year ago

When "unlocking" the funds of an expired Fidelity Bond, it is automatically placed in Jar A. It would be nice for if users had the ability to select a different destination jar.

Originally posted by @dergigi in https://github.com/joinmarket-webui/jam/issues/556#issuecomment-1348186319

It is now changed to skip the jar selection and default to Jar A automatically - the code to select a Jar is still present for now and can be enabled with a flag - hope that is okay (in case it is decided to enable this flow or provide a toggle).

If we want to keep it in, we could add an Unlock Options to the Unlock modal, just like we have on Receive?

Add this "fold" ...

Screenshot 2022-12-13 at 11-53-26 Jam for JoinMarket

...to this screen:

Screenshot 2022-12-13 at 11-54-49 Jam for JoinMarket


Would still default to A (unless you go through the trouble of changing it) and would hide the complexity nicely, while still providing the option.

editwentyone commented 1 year ago

we could use an already existing modal for that, please see: https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=5305%3A65790&t=W3bN2LpMzw9y9okA-11

image