joinmarket-webui / jam

Your sats. Your privacy. Your profit.
https://jamapp.org
MIT License
264 stars 54 forks source link

Need an easy way to sign a message #633

Open bota87 opened 1 year ago

bota87 commented 1 year ago

Is your feature request related to a problem? Please describe.

Some services require you to sign a message with the address you want to use to receive

Describe the solution you'd like

A tool that ask for the address, the message to sign and return the signature, like sparrow/electrum wallets

theborakompanioni commented 1 year ago

Hey @bota87! Thanks for the feature request. It would be nice to have this ability in Jam, however, such functionality is currently not exposed via the JM API. Would it be sufficient to use the CLI? I think wallet-tool.py exposes a command signmessage which should be exactly what you are looking for.

bota87 commented 1 year ago

Yeah I've solved with wallet-tool but it's a little bit tricky, especially having to set the hd wallet path instead of the address. docker exec -it jam wallet-tool.py -H "m/84'/0'/2'/0/2" /root/.joinmarket/wallets/jam_wallet.jmdat signmessage "the message to sign"

theborakompanioni commented 1 year ago

Yeah I've solved with wallet-tool but it's a little bit tricky

:+1:

If this feature will find its way into the JM API, Jam will happily adopt it!

bota87 commented 1 year ago

Ok I've opened an issue on JM repo, let's see how it goes :crossed_fingers:

theborakompanioni commented 10 months ago

Ready for development. See https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1536 (not merged yet).

kristapsk commented 10 months ago

Ready for development. See JoinMarket-Org/joinmarket-clientserver#1536 (not merged yet).

Waiting for feedback from you or somebody else that it works well with Jam, then will merge.

theborakompanioni commented 10 months ago

ping @editwentyone

editwentyone commented 10 months ago

first draft, more clarification tomorrow in sync call https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?type=design&node-id=3283-85955&mode=design&t=6FQUVMTrmfxSlFjm-11

editwentyone commented 10 months ago

new update after call: https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?type=design&node-id=6600-17405&mode=design&t=5062kYXLtdJFrL4Y-11

image