search

joinmarket-webui / jam

Your sats. Your privacy. Your profit.
https://jamapp.org
MIT License
257 stars 52 forks source link

Fee configuration is not saved #667

Open f321x opened 12 months ago

f321x commented 12 months ago

Expected behavior

Going to settings, setting fee rates for tx and collaborators, doing cj, coming back after a week, doing cj again and it uses the previously configured fees

Actual behavior

Configured fees are reset to their standard values again each time the user tries to do a cj

Steps to reproduce the problem

  1. Set fees
  2. Do cj
  3. Come back later, do cj again -> standard fees

Specifications

Additional context Maybe this is intended to not forget about too low tx fees but its somewhat annoying, at least the collaborator fees should be persistent

theborakompanioni commented 12 months ago

Hey @f321x, thanks for the report. :pray:

Maybe this is intended to not forget about too low tx fees but its somewhat annoying, at least the collaborator fees should be persistent

Unfortunately, it is not really a bug, but an existing (intentional?) "limitation" of JM. There is a ticket discussing this: https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1104 (Want to chime in an "bump" it?)

In the meantime, depending on your install method (i.e. the integration you are using - e.g. does not work on systems using the standalone docker image, like Umbrel/Citadel), you can adapt the joinmarket.cfg yourself, and the settings will survive a node restart.

Only thing we can currently do is to make users aware of the fact.

These settings will be reset to default values when the JoinMarket service restarts, e.g. on a system reboot.

Also.. thought about adding "Adapt fee settings" as distinct step to the "cheatsheet".. do you think this is a good idea, till the ticket mentioned above is resolved? Do you have another idea, how this can be better communicated?

f321x commented 12 months ago

Thx for the detailed explanation and quick action. I think it would be very useful to have a small explanation of this behavior in the fee settings, like in your screenshot. This way the user at least doesn't think it is a bug which makes it overall less confusing.

Personally i wouldn't put it in the cheatsheet as it's a more advanced, optional setting and coinjoining works fine with the standard settings (maybe just a bit more expensive). I guess this would bloat the cheatsheet, making it more confusing for new users that need the cheatsheet.