feat(orderbook): show fidelity bond value and locktime

[theborakompanioni]

Resolves #754.

Displays amount and expiration date of fidelity bonds in the orderbook overlay.

How to test

Create a fidelity bond for one of the dev makers (e.g. on localhost:29080 - you need to stop the maker, create a fidelity bond, and restart the maker again). Then, reload the orderbook on the main dev instance and verify that the correct Fidelity Bond information is displayed.

:camera_flash:

[theborakompanioni]

I am not sure if I am doing it the right way. please help!! Though code part looks completely fine to me.

It might take some time before the bond value appears - it worked for me after refreshing a couple of seconds later. Can you try it again? :pray:

Edit: There is a message "It might take some time for your offer and your bond to appear in your local orderbook." but it is not displayed, when your own offer is already included in the orderbook. Maybe it should be shown till offer and bond (if the user holds a bond) are displayed?

[barrytra]

It might take some time before the bond value appears - it worked for me after refreshing a couple of seconds later. Can you try it again? 🙏

It got displayed but its value is 0.

[theborakompanioni]

It might take some time before the bond value appears - it worked for me after refreshing a couple of seconds later. Can you try it again? 🙏

It got displayed but its value is 0.

Have you waited a couple of seconds and refreshed once or twice?

[barrytra]

are you asking me to wait after creating FB but before start earning?

[theborakompanioni]

are you asking me to wait after creating FB but before start earning?

No, wait a little bit after you started the maker and the offers appears in the orderbook while the bond value is zero. Refresh the orderbook from time to time. The bond value should appear a bit delayed (your orderbook watcher actually contacts every maker–in this case "yourself"–in order to get the bond info).

Hint: You can use the Refresh button on the orderbook overlay.

[barrytra]

ok i'll try that.. What i understand is that value initially will be 0 and then it will increase.. right?

[theborakompanioni]

ok i'll try that..

Thanks :pray: Please report back.

What i understand is that value initially will be 0 and then it will increase.. right?

Zero means there is no bond (or not yet loaded). This is actually a good point.. do you think it would be better to show something else? e.g. or a "no bond" label?

[barrytra]

I refreshed it many times but still its value is still 0. Don't know if i am doing something wrong?

Zero means there is no bond (or not yet loaded). This is actually a good point.. do you think it would be better to show something else? e.g. or a "no bond" label?

we can do that but i think at the same time it can be confusing for the user as well. Maybe we can add some more info for user when value is 0(no bond) when he hovers over it.

[barrytra]

Okay this works fine now. There is still one issue left:

• This doesn't look much pleasing in light mode, that needs to be fixed. We can probably fix it here or in some other PR

[theborakompanioni]

Okay this works fine now.

Glad it worked out. Should have mentioned that the FB needs some confirmations :facepalm: Sorry :grimacing:

There is still one issue left:

* This doesn't look much pleasing in light mode, that needs to be fixed.
  We can probably fix it here or in some other PR

You are right. Balances in "light mode" on dark backgrounds (e.g. tooltips) are a problem. Needs to be addressed - I'd say it is okay to do in a follow-up PR. Okay for you?

[theborakompanioni]

yes we can do that in follow-up PR.

Agreed. Tracked in #770. Thanks @barrytra! :pray: