search

joinmarket-webui / jam

Your sats. Your privacy. Your profit.
https://jamapp.org
MIT License
236 stars 48 forks source link

ui: Improve readablity of balances in light mode on dark backgrounds #770

Open theborakompanioni opened 1 month ago

theborakompanioni commented 1 month ago

Balances do not look very nice in light mode on dark backgrounds, e.g. in tooltips. They should be made more readable and easy on the eyes.

Screenshot from 2024-05-28 23-09-32

Originally posted by @barrytra in https://github.com/joinmarket-webui/jam/issues/766#issuecomment-2135791517

SnehalSrivastava27 commented 5 days ago

@theborakompanioni is this issue still open ?

barrytra commented 5 days ago

@SnehalSrivastava27 Yes it is!!

SnehalSrivastava27 commented 5 days ago

@barrytra Can I take up this issue

barrytra commented 2 days ago

Lets discuss it here @SnehalSrivastava27 Can u show me what error do u get on running npm run regtest:rebuild and npm run regtest:up

SnehalSrivastava27 commented 2 days ago

This is what I get on npm run regtest:rebuild image

and This is what I get on npm run regtest:up image

SnehalSrivastava27 commented 2 days ago

I am almost ready with solving the issue but facing problem in running backend

barrytra commented 2 days ago

Are you inside the cloned Jam directory when you make these commands?

SnehalSrivastava27 commented 1 day ago

@barrytra yes

barrytra commented 1 day ago

@theborakompanioni Can you have a look at the errors?

theborakompanioni commented 15 hours ago

@theborakompanioni Can you have a look at the errors?

@SnehalSrivastava27 The first error is while building a docker image and could be related to network issues, so it might be temporary. Can you re-run the command?

Regarding the second error: Since it seems you are using some version of Windows, I am afraid I cannot reproduce the issue. I would have thought there is some kind of posix subsystem to make it work ("Windows Services for Linux", WSL?) or something.. (but I am not familiar with it and hence unable to help).

So.. if you care about it enough.. use your favourite search engine to search for that or–and this is a personal opinion, please don't get it the wrong way–use a proper operating system for your development work. :wink:

kristapsk commented 3 hours ago

Regarding the second error: Since it seems you are using some version of Windows, I am afraid I cannot reproduce the issue. I would have thought there is some kind of posix subsystem to make it work ("Windows Services for Linux", WSL?) or something.. (but I am not familiar with it and hence unable to help).

WSL2 is the way to go for Windows nowadays. It allows to run Ubuntu or whatever Linux distro you want under Windows 10/11.

P.S. "Windows Subsystem for Linux" (not "Services"). :)

SnehalSrivastava27 commented 3 hours ago

@theborakompanioni in the first issue I have run the command several times will try to run few more times