joinmarket-webui / jam

Your sats. Your privacy. Your profit.
https://jamapp.org
MIT License
236 stars 48 forks source link

fix(fb): display error alert in modal #776

Closed barrytra closed 1 month ago

barrytra commented 1 month ago

fixes #775 The alert message has been shifted inside modal. However I was not able to produce the error locally, so its requested to produce the error locally while reviewing it. and please let know if it works fine. PS: If anyone gets to know how to produce error, I would love to learn it as well.

theborakompanioni commented 1 month ago

PS: If anyone gets to know how to produce error, I would love to learn it as well.

e.g. this gets triggered when the wallet is not "Fidelity Bond"-enabled, when the wallet is created via the CLI and the users presses n on the question Would you like this wallet to support fidelity bonds? (https://jamdocs.org/FAQ/#how-to-import-an-existing-wallet-via-the-command-line).

We could load the timelocked address immediately after selecting the date, so the error would get triggered earlier in the process. Currently the user selects a UTXO and only then the address is loaded.. maybe this can be considered in #650?

PR looks good! Approved :rocket: