search

joint-online-judge / horse

The new generation of JOJ Backend.
https://joint-online-judge.github.io/horse/
MIT License
5 stars 3 forks source link

Bug: commit without config.json #109

Closed nichujie closed 2 years ago

nichujie commented 2 years ago

Upload data first, and then commit immediately without updating config.json. We get:

image

After that, we make a commit again, and we get:

image

What happened: after first commit, files are committed to LakeFS. However, there are no config.json and the request failed.

nichujie commented 2 years ago

Redesign:

  1. Considering current workflow, there's no need to show uncommitted files and make a commit manually. The backend shall make a commit immediately after adding the files changes.
  2. "Get Problem Config Json" shall still return the rest data with an empty config object.

Issue: the original config.json will disappear if the user upload a dataset archive without config.json. Would be better to:

  1. Copy original config.json to new repo when uploading a new dataset without config.json.
  2. Do nothing when uploading a new dataset with config.json.