Domain User Info - Githubissues

joint-online-judge / horse

The new generation of JOJ Backend.

https://joint-online-judge.github.io/horse/

MIT License

5 stars 3 forks source link

Domain User Info #98

Open nichujie opened 2 years ago

nichujie commented 2 years ago

Following APIs should return UserDetailWithDomainRole instead:

Get domain user: https://github.com/joint-online-judge/horse/blob/1ba920196656002bdd11317a6b8f86b42bc24879/joj/horse/apis/domains.py#L221
List domain user: https://github.com/joint-online-judge/horse/blob/1ba920196656002bdd11317a6b8f86b42bc24879/joj/horse/apis/domains.py#L185

BoYanZh commented 2 years ago

The permission for these is Permission.DomainGeneral.view, which is a little too wild. Does it mean everyone in the domain can see the real name of other users?