Be quieter about remote hosts with invalid SSL certs

jointakahe / takahe

An ActivityPub/Fediverse server

BSD 3-Clause "New" or "Revised" License

1.12k stars 86 forks source link

Be quieter about remote hosts with invalid SSL certs #591

Closed osmaa closed 1 year ago

osmaa commented 1 year ago

I was getting a lot of extremely verbose log messages and sentry errors about SSLErrors from remote hosts. Since I can't do anything about a bad certificate on someone else's server, and the SSLError anyway prevented any processing with those hosts, this patch replaces the error with a one-liner log message:

2023-06-24T19:32:44.009595000Z https://some.skrolli.fi/users/skrollilehti [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1002)

andrewgodwin commented 1 year ago

Yeah, I was just poking around this morning looking at this as there's a few misskey instances with bad SSL that are hitting our Sentry. I'll happily accept it once you fix the linting.

osmaa commented 1 year ago

late night editing on wrong branch. closing this one.