jointakahe / takahe

An ActivityPub/Fediverse server
BSD 3-Clause "New" or "Revised" License
1.1k stars 84 forks source link

signatures need to use UTF-8 in order to represent all URLs #633

Closed osmaa closed 11 months ago

osmaa commented 11 months ago

Noticed this as an error pulling some signed requests as URLs with international character sets couldn't be encoded. Having reviewed Mastodon implementation, I believe it is correct to encode URLs using UTF-8. This changes nothing for majority of content since ASCII charset encodes the same way.