search

jointakahe / takahe

An ActivityPub/Fediverse server
BSD 3-Clause "New" or "Revised" License
1.1k stars 84 forks source link

ignore unknown tag type in incoming post, rather than raise exception #639

Closed alphatownsman closed 11 months ago

alphatownsman commented 11 months ago

Various ActivityPub implementations and proposals introduced tag types, e.g. Edition from Bookwyrm and Link in fep-e232 Object Links, and assume this list will continue to grow.

Given most folks behind these changes will consider backward compatibility and making things pain-less for other implementations, it should be generally safe for us to just ignore the tag type and treat the post as is, rather than to raise exception and discard the whole post.

Personally, I think fep-e232 inline quote is really interesting, and backed by most implementations like Pleroma/Misskey/Firefish except Mastodon, but that can be its own pr in the future.

andrewgodwin commented 11 months ago

Agreed - a lot of this code was written to raise exceptions when I was developing it so I could discover compat holes, but that's less useful now.