search

jointakahe / takahe

An ActivityPub/Fediverse server
BSD 3-Clause "New" or "Revised" License
1.1k stars 84 forks source link

focalpoints are floats between -1..1, not int #648

Closed osmaa closed 8 months ago

osmaa commented 8 months ago

https://docs.joinmastodon.org/api/guidelines/#focal-points

(another thing caught via a sentry alert)

andrewgodwin commented 8 months ago

Does this not need a database migration?

osmaa commented 8 months ago

it does. I wasn't sure what to do with the autogenerated file

osmaa commented 8 months ago

adding the test case for this i noticed that attachment.to_ap() wasn't producing the (under-specced) Mastodon focalPoint tuple, so that's now added, too.

What I haven't tested is whether defining a focal point through a client app actually goes through end-to-end. I suppose it should, now..

andrewgodwin commented 8 months ago

Thanks!