jointakahe / takahe

An ActivityPub/Fediverse server
BSD 3-Clause "New" or "Revised" License
1.1k stars 83 forks source link

Relay support #686

Open alphatownsman opened 6 months ago

alphatownsman commented 6 months ago
alphatownsman commented 6 months ago

@andrewgodwin any suggestion to get this merged?

andrewgodwin commented 6 months ago

Well the problem is that we've now reached my cutoff time for keeping working on the project if nobody turns up to help full time, so there is a chance this may never get merged. It'll definitely have to wait at least until there's another maintainer who can help review it, sadly :(

AstraLuma commented 5 months ago

Given the vibe of relay discussion, this seems like a surprisingly small change? Does this cover inbound, outbound, and handshaking?

Are there any documents describing the relay protocol?

alphatownsman commented 5 months ago

@AstraLuma yes it should cover all relay functions.

There are some fundamental protocol issues we discussed previously preventing it from working with certain relays and peer servers, like the infamous as:Public issue, but i think we should track that in different PR.

I have been running this no problem on my own server for two weeks, the only issues are very occasionally some less known server implementations may send some weird message json breaking Post parser but thats not relay issues and should be fixed separately.

There are some doc in #641

AstraLuma commented 5 months ago

Ok, thanks. I'm going to take some time to go over this carefully because the state machines smell of fiddly and precise.