search

jojkaart / ComfyUI-sampler-lcm-alternative

ComfyUI Custom Sampler nodes that adds a new improved LCM sampler function
GNU General Public License v3.0
123 stars 13 forks source link

Don't round ancestral and noise_mult #3

Closed Simn closed 9 months ago

Simn commented 9 months ago

Seems like this locks the values at 1.0, 2.0 etc., so I don't think we want that here. I've also changed the step for noise_mult to 0.01 because lower values make it look like clicking the < and > buttons doesn't do anything.

jojkaart commented 9 months ago

Oh, I interpreted the round to mean rounding at the precision specified. Now that I tried to see if I could find the code, I happened to find the documentation instead in custom_nodes/example_node.py.example. Apparently round is set to the precision value by default. Documentation didn't specify what happens when round is boolean True, so I assume this fix will actually achieve what I wanted to.

That said, I seem to remember noise_mult working like I expected. You'll want to stick to values very close to 1.0 with that one, results won't be good otherwise. That's why I'm a bit reluctant to increase the step. Might be worthwhile to rethink how to express that value.

In any case, I've been thinking to combine all the nodes into one node that does everything once I get the motivation to work on that. Yes, including the scheduler, the splitsigmas node is clumsy to use and it'd bring all the parameters into one place.

jojkaart commented 9 months ago

So, after thinking on this a bit, don't remove the round parameter, instead, set it to False. Then the precision is not a problem and the step buttons don't seem like they don't work either.

Simn commented 9 months ago

Ok I realized that the problem was that I had the shown decimal places set to 2. I thought this was the default in ComfyUI, but apparently I changed this at some point and forgot. So with the default setting, the 0.001 step is indeed not a problem.

I don't really understand what the difference is between setting round to False vs. just omitting it, but I've made the change accordingly!

jojkaart commented 9 months ago

The difference is that the round setting actually defaults to being equal to the step setting while false disables it.