search

jojo2357 / MDRP-MusicBee-Bridge

5 stars 0 forks source link

bridge doesn't automatically start MDRP (preferences not being saved) #2

Closed RoguedBear closed 3 years ago

RoguedBear commented 3 years ago

When setting the MDRP.exe path in plugin settings in musicbee UI, after i get a check mark when i hit save and restart musicbee MDRP isn't opened. Manually openening MDRP, it detects the bridge (it says that in the console).

When i opened the preference page, the plugin settings were back to default. empty path, imagepack standard and "Close MDRP on mb" checked.

If i enter the path and check auto start again and hit save and then open the preferences page again its back to default again. As if the preferences are not being saved.

Though after manually starting MDRP and then i close mb, MDRP is also closed.

Would be glad to provide any logs if possible.

-- (Great job on the v1.6.0 updates and the musicbee plugin btw 🥳 )

jojo2357 commented 3 years ago

I have this issue replicated, although I don't know how I missed it 🤔. In the meantime, you can use the backdoor settings way.

  1. In the top right theres 3 rectangles in a square with a tooltip of Configure Layout. Click that
  2. Arrange Panels
  3. Under available elements, select mdrp bridge
  4. Apply/save.
  5. Now there should be something extra on your layout with the title MDRP Status. Click the image and a settings window should pop up.
  6. Hopefully that works for now while I get a patch out for this

Also, glad to see you again and I always appreciate your thorough issue reports :)

jojo2357 commented 3 years ago

Interesting issue for those following at home, after loading the combobox with a data source, items is null unless you give it a BindingContext. Why? I dunno but the issue seems to be resolved, please verify once i make 1.0.1 release

RoguedBear commented 3 years ago

I tried the new dll, and the settings are being saved but here's the weird thing.

First i tried to save via the preferences menu in mb... didn't save Then i tried the panel layout workaround you suggested. The settings were saved in that plugin menu, persisted an application restart and was also reflected in the mb preferences page.

Now i tried changing the settings via the mb preferences menu, and now settings are being saved from there as well. 😄

i guess that solves it ¯\(ツ)/¯

(Also i love the programmer image pack :>)

jojo2357 commented 3 years ago

I tried replicating the issue but despite fully uninstalling and reinstalling the plugin and associated settings, I could not replicate it. Maybe someone else will come along and say they still have the issue, but I will close this for now and also add the issue templates.

I mostly use the programmer pack because the standard pack was made by me and its pretty bad imo. That one should also be called the standard pack :joy:

Smaltin commented 3 years ago

(Also i love the programmer image pack :>)

Glad to see you enjoy it, I'm planning on making more packs whenever I get around to it

RoguedBear commented 3 years ago

Having more packs would be such a cool nice little addition!! I appreciate you both bringing out new features to this project :v: