search

jojo2357 / Music-Discord-Rich-Presence

Provides groove discord rich presence for media playing on a computer
MIT License
71 stars 8 forks source link

Add imgur support and Amazon Music Support #83

Open Cxsmo-ai opened 1 year ago

Cxsmo-ai commented 1 year ago

add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc and also add amazon music support like this has https://github.com/cytsai1008/bezos-presence but improve artist and song name detection

jojo2357 commented 1 year ago

There is currently "remote arts" which attempts what imagur does. I do not have any plans to integrate that at this time.

Amazon music was looked into, but seeing how your referenced link uses the same api as I do, there is nothing I can do better than it, and amazon music was unreliable and hard to test. is it better now?

Cxsmo-ai commented 1 year ago

but is there a way to get amazon music rpc working the way you currently have it but with imgur api image fetching.

jojo2357 commented 1 year ago

What do you mean by "imgur api image fetching"? Is that different than what I already have, and if so, please elaborate.

Cxsmo-ai commented 1 year ago

you can use the imgur api and imgur api key to have the cover art be pulled from imgur like this does https://github.com/Radiicall/jellyfin-rpc

Cxsmo-ai commented 1 year ago

and also this has better song detection then your rpc for amazon music https://github.com/cytsai1008/bezos-presence

jojo2357 commented 1 year ago

I just realized that you are the author of #72 as well. please revisit it as nothing has changed. maybe amazon music has changed, but there is nothing more I will do on that front.

As for imgur: please explain to me in words what you would like. Stop sending me url's and explain what MDRP needs to do that it can't already do.

Smaltin commented 1 year ago

you can use the imgur api and imgur api key to have the cover art be pulled from imgur like this does https://github.com/Radiicall/jellyfin-rpc

The imgur part in the Jellyfin RPC is simply to host the images of the movies externally instead of setting up port forwarding. The current MDRP fetches the images from an API and caches the URL to that file, making Imgur unnecessary.

add amazon music support like this has https://github.com/cytsai1008/bezos-presence but improve artist and song name detection

For Amazon Music, in DiscordPresenceConfig.ini add amazon music=true=808571949227049000 at the top of the page. As mentioned previously in #72 there's not much more we can do