search

jojo2357 / kiwix-zim-updater

A script to check `download.kiwix.org` for updates to your local ZIM library.
GNU General Public License v2.0
77 stars 5 forks source link

Invalid args does not immediately halt script #8

Closed jojo2357 closed 1 year ago

jojo2357 commented 1 year ago

Running kiwix-zim.sh with no extra arguments does not error out immediately, despite the obvious misconfiguration. May I suggest checking the ZIMPath is present before calling master_scrape? I would also suggest a much more scalable args parser. Rather than hardcoding support for only 3 args.

jojo2357 commented 1 year ago

Fixed by #9

DocDrydenn commented 1 year ago

Nice! Thanks for the help.