Viridian Forest 2x2 block encounter glitch not fixed

jojobear13 / shinpokered

Mostly-vanilla hack of Pokémon Red/Blue focused on bugfixes and trainer ai

210 stars 42 forks source link

Viridian Forest 2x2 block encounter glitch not fixed #210

Closed Mord5 closed 1 year ago

Mord5 commented 2 years ago

The Viridian Forest no encounter grass tiles glitch is still in effect. (ROM built from https://github.com/jojobear13/shinpokered/commit/cc28c3da068a883bdfe37406eb6251d467cc40e9.)

https://github.com/jojobear13/shinpokered/blob/cc28c3da068a883bdfe37406eb6251d467cc40e9/engine/battle/wild_encounters.asm#L28

Is this behavior intentional in shinpokered?

jojobear13 commented 2 years ago

Somehow that file got reverted. Fixed in 363cb6ea0a44b7582b046d74c3b560ce45313130. Slated for next release.

jojobear13 commented 2 years ago

Going with this 237539e3d9ae172ddb43039f2c48b3f98fd8ba29 as a solution. More elegant, takes up less space, and harder to mess something up with a typo. I suspect that Gamefreak waffled back and forth on which tile (bottom left or right) was supposed to be used for encounters. Settling on bottom-left is probably what should have been done.