search

jojobear13 / shinpokered

Mostly-vanilla hack of Pokémon Red/Blue focused on bugfixes and trainer ai
210 stars 42 forks source link

Bug: Bike voucher cannot be removed under certain conditions #217

Closed jojobear13 closed 1 year ago

jojobear13 commented 2 years ago

What emulator and/or hardware are you are using? BGB

Which patch are you using? 1.23 master

What is the problem you encountered? If you have the Bike Voucher in your not-currently-active bag item list, it doesn't get removed when you receive the Bicycle. You end up with both the Bicycle and Bike Voucher in your inventories.

Expected behavior Bike voucher needs to be removed from even if its in the inactive bag

jojobear13 commented 2 years ago

Also affects anything using RemoveItemByID such as fossils and giving guards a drink.

jojobear13 commented 2 years ago

resolved in commit 33bb98a305baca8b92700a3eddece7fed2a38311