search

jojobear13 / shinpokered

Mostly-vanilla hack of Pokémon Red/Blue focused on bugfixes and trainer ai
209 stars 42 forks source link

Clipping through walls? #251

Closed DiabloStorm closed 12 months ago

DiabloStorm commented 1 year ago

Click Cerulean Cave

jojobear13 commented 1 year ago

Problem confirmed to be a vanilla bug.

image

DiabloStorm commented 1 year ago

Huh. interesting.

jojobear13 commented 1 year ago

Notes to self. Tile collision coordinate structure. Red are tile coordinates occupied by player. Coordinate 8,9 is defined as the player's tile. Yellow are the tiles that are checked for collision.

image

DiabloStorm commented 1 year ago

So. Another thing about collision. What do you think about the vanilla game playing the "thump" sound when exiting buildings?

Duno if you noticed it.

Example: Building entrance is one tile, building exit is usually 2 tiles, I think if you exit the building on the tile other than the one it puts you on, the "thump" plays but you still go through the door.

jojobear13 commented 1 year ago

Looks like I might be able to check for the warp flag and deny the thump from playing. image

DiabloStorm commented 1 year ago

Looks like I might be able to check for the warp flag and deny the thump from playing.

It's just an oddity I noticed. Do what you will.

jojobear13 commented 1 year ago

fixed in 7f87439982982b4b1a3e4465f17953af672d8520 as well as aed74701c88cb44499878e1baf02d0a4a622d8d5