jojojames / dired-sidebar

Sidebar for Emacs leveraging Dired
GNU General Public License v3.0
513 stars 22 forks source link

Error when other windows are dedicated #55

Closed rekado closed 3 years ago

rekado commented 3 years ago

Here's a recipe to reproduce this:

(require 'dired-sidebar)
(toggle-debug-on-error)
(set-window-dedicated-p (selected-window) t)
(dired-sidebar-toggle-sidebar)

Now visit a file by hitting RET or clicking on it. I get this error:

Debugger entered--Lisp error: (wrong-type-argument window-live-p nil)
  select-window(nil)
  dired-sidebar-find-file("/home/rekado/dev/guile-studio/guile-studio-configu...")
  dired-sidebar-mouse-subtree-cycle-or-find-file((mouse-2 (#<window 15 on :~/dev/guile-studio/> 748 (94 . 183) 1035065982 nil 748 (11 . 10) nil (6 . 13) (8 . 17))))
  funcall-interactively(dired-sidebar-mouse-subtree-cycle-or-find-file (mouse-2 (#<window 15 on :~/dev/guile-studio/> 748 (94 . 183) 1035065982 nil 748 (11 . 10) nil (6 . 13) (8 . 17))))
  call-interactively(dired-sidebar-mouse-subtree-cycle-or-find-file nil nil)
  command-execute(dired-sidebar-mouse-subtree-cycle-or-find-file)
jojojames commented 3 years ago

Thanks for the report, can you try the latest and report back if it doesn't work.