Rename toggle variables to either drop -p suffix or all adopt it?

jojojames / dired-sidebar

Sidebar for Emacs leveraging Dired

GNU General Public License v3.0

506 stars 22 forks source link

Rename toggle variables to either drop -p suffix or all adopt it? #71

Closed DivineDominion closed 2 years ago

DivineDominion commented 2 years ago

Going through the code, I noticed that there's dired-sidebar-one-instance-p since #39; but other boolean toggles that are user-facing don't have the -p suffix, e.g.:

dired-sidebar-pop-to-sidebar-on-toggle-open
dired-sidebar-no-delete-other-windows
dired-sidebar-use-term-integration

My suggestion would be to rename dired-sidebar-one-instance-p to dired-sidebar-use-one-instance because that's least invasive (and I personally like the "speaking" variable names).

What do you think?

jojojames commented 2 years ago

Good suggestion, could make the change but also keep the old version as an alias to the new variable name. Open for PR.

jojojames commented 2 years ago

Changed