Add memoize() method to Builder

[GoogleCodeExporter]

This is good for consistency, so users using the Builder directly don't
have to catch the run() exception by hand.

Original issue reported on code.google.com by llu...@gmail.com on 31 Jul 2009 at 9:57

Attachments:

• 0001-Add-memoize-method-to-Builder.patch

[GoogleCodeExporter]

The previous patch has a bug, the global run() function was called from
Builder.memorize() instead of self.run().

Attached is a patch that fixes that problem.

Original comment by llu...@gmail.com on 2 Aug 2009 at 9:16

Attachments:

• new.patch

[GoogleCodeExporter]

Original comment by benh...@gmail.com on 2 Aug 2009 at 10:04

• Changed state: Verified

[GoogleCodeExporter]

Please, note that you committed the patch with the bug in the revision r34. You
should replace the run() call with self.run() to be able to work with a custom 
builder.

Original comment by llu...@gmail.com on 2 Aug 2009 at 10:20

[GoogleCodeExporter]

Ah, good catch, fixed now in r35. Some of these things we wouldn't otherwise 
find
very quickly, because we use run() in our build scripts and not memoize() -- 
thanks. :-)

Original comment by benh...@gmail.com on 2 Aug 2009 at 11:34

[GoogleCodeExporter]

Maybe is time for some unit testing... But I suck at it, so I guess I won't be
sending patches for that ;)

Original comment by llu...@gmail.com on 2 Aug 2009 at 11:46