search

joke2k / django-environ

Django-environ allows you to utilize 12factor inspired environment variables to configure your Django application.
https://django-environ.rtfd.org
MIT License
2.96k stars 315 forks source link

Test on Django 5.0 #506

Closed adamchainz closed 8 months ago

adamchainz commented 8 months ago

New Django version incoming!

I copied from #456 for this update. Running the tests locally, I found no failures or new warnings, so it appears that django-environ is compatible.

I would recommend dropping old Django versions that are no longer supported. Would you be interested in a follow-up PR doing so?

coveralls commented 8 months ago

Coverage Status

coverage: 92.612% (+0.3%) from 92.268% when pulling 79b30c73d6f4e362cb6efb53ad50bd0313e753be on adamchainz:django_5.0 into e3e7fc9551858d1a41ed21ff7e46245e4f97652c on joke2k:develop.

sergeyklay commented 8 months ago

Thank you!

adamchainz commented 8 months ago

Thanks for merging. Can you respond to my question about dropping old versions?

sergeyklay commented 8 months ago

I would recommend dropping old Django versions that are no longer supported. Would you be interested in a follow-up PR doing so?

We strive to support all Django versions up to the latest and do not plan on dropping them without a compelling reason. At this point, I see no reason to deprive users who, for various circumstances, are using older versions of Django from receiving library updates. Dropping support for older versions would only be considered if there is a substantial rationale for doing so.