search

joke2k / faker

Faker is a Python package that generates fake data for you.
https://faker.readthedocs.io
MIT License
17.65k stars 1.92k forks source link

Aiming to add faker for book genres and titles #1901

Closed dmitry-goryachev closed 9 months ago

dmitry-goryachev commented 1 year ago

I have opened this ticket because while I was using the faker in my project for creating books on a website, I found there is no community made faker for books. I would like to contribute to faker by letting it generate:

Steps to reproduce

  1. Fork the repository
  2. Using the already existing music faker, reproduce the same kind of faker for the books, altering the concept if item creation from music-related to book-related.
  3. Write some tests for the addon of mine.
  4. Use pylint to check my code style and read guides to code style the faker repo provides
  5. Correct the code style and optimize performance
  6. Submit a pull request to the repository

Expected behavior

the faker can fake book meta info (contentless).

Actual behavior

the faker still cannot fake the books

dmitry-goryachev commented 1 year ago

I mentioned above I expect the book to generate isbn. This faker feature exists already, I remembered. So everything else remains, isbn will not be developed

fcurella commented 1 year ago

Hi @dmitry-goryachev !

Feel free to create an external community provider like the music one. Once it's done, I'll be happy to add it to the list!

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 9 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.