Invisible icon in toolbar when using new fluent icon style (npp v8 onwards)

jokedst / CsvQuery

Plugin for Notepad++ that treats CSV files as (read only) SQL tables

153 stars 28 forks source link

Invisible icon in toolbar when using new fluent icon style (npp v8 onwards) #28

Closed puffpppp closed 3 years ago

puffpppp commented 3 years ago

Using Default Style: Using new style:

Saw below comment on the compare plugin page:

specifically, plugin authors need to call NPPM_ADDTOOLBARICON_FORDARKMODE instead of NPPM_ADDTOOLBARICON if Notepad++ v8.0 or newer. (Actually, I don't think it hurts to call both, to keep the plugin compatible with older versions...)

jokedst commented 3 years ago

Wow. Thanks for the bug report (been on vacation so didn't see it until now). Kinda bad by Npp to break all plugin icons out there... But I'll try to make a fix.

jokedst commented 3 years ago

Ok, seems like Npp got the hint from other users, there is a fix that will allow old plugins to at least show their old icons in dark mode: https://github.com/notepad-plus-plus/notepad-plus-plus/commit/302bab894fd421fde371e04247357bc45728d729

It will be in next release I guess.

However, the CsvQuery icon still looks like crap in dark mode. You can't see the "CQ", it just looks like some sort of crosshair.. :P So I'll still have to fix this, but it's not as urgent.

jokedst commented 3 years ago

This is now fixed, and v1.2.8 has been published and merged to the plugin admin list